Repository navigation
Conversation
Check acceleration and jerk magnitudes at polynomial extrema as well as interval endpoints, so output sampling cannot hide an infeasible path. Normalize time and derivative amplitude while finding stationary points. Co-Authored-By: ChatGPT (GPT-6 Astra Pro) <noreply@openai.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 12 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The quintic planner checks acceleration and jerk only at its returned samples. It can therefore accept a continuous trajectory that exceeds the requested limits between samples.
For a rest-to-rest move of one unit,
dt=5,min_t=5andmax_acc=0.1, main accepts a five-second path whose sampled acceleration is approximately zero. Its actual peak is 0.230940. A separate polynomial has zero endpoint jerk but an interior jerk peak of 1.5, which is also missed by coarse sampling.Change
Evaluate acceleration and jerk magnitudes at the interval endpoints and the real stationary points of their squared planar norms. Normalize both time and derivative amplitude when finding these points, then evaluate the original components with
hypot. The returned samples and their signed profiles retain their existing format.Behavior change: output sampling no longer determines whether a continuous path satisfies the limits. A previously accepted path may use a longer candidate duration or raise
NoPathErrorwhen no feasible duration exists.Validation
mypy: all 166 source files passed. New tests pass Ruff lint/format;git diff --checkpasses.Prior work
Checked all 107 prior fork heads and relevant upstream patches. The only older QuinticPolyPlanner source is identical to main: #909 fixes terminal sampling but retains sample-only limits. #781 adds the failure contract and fixes goal inputs; #736 conditions the separate scalar trajectory generator. None checks continuous path extrema.
Primary contributor: Afloat16.
Prepared with ChatGPT (GPT-6 Astra Pro) assistance.